BUG: Fix bug with over-updating and antialias toggle #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmarkowitz feel free to take a look and click "approve" if you're happy and I'll merge |
|
This is a pretty trivial change so marking for merge-when-green after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In finding #270 I noticed that just opening the Settings dialog triggered 3 updates. There is no reason this is necessary, and is an unnecessary slowdown. It happens because we connect the listener then set the value (to it's currently used value)... which triggers an update.
And this is a bug for
antialiasingactually because it triggers an AA toggle, so if you had AA on, it connected the listener, set thesetChecked(True)which initiated a toggle, disabling AA. So the check state was always out of phase with the actual state.