-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up, update packaging, fix imports #71
base: master
Are you sure you want to change the base?
Conversation
@dengemann Do you remember what the Also, @dengemann or @alexrockhill would you have the datasets required to run the tutorials and examples? It's almost the last piece missing to get the build green. |
That looks like a |
That's what I assumed and I removed it ;) |
Dennis was saying last time that all the data is stored on AWS so that the CIs can run it but we can't store them somewhere accessible because of dataset protections. You can download the dataset here though: https://db.humanconnectome.org/, it's not too hard to do, you just have to register an account and agree to the license. |
@larsoner probably this is worth having a look re: mne-tools/mne-python#12731 |
@mscheltienne ideally the reformatting changes would be in a separate PR so they could be added to I think we also want some very minimal CI runs -- I'll open a quick PR to add those first, then merging |
IIRC, I started to look into fetching the HCP dataset from AWS to test the changes in this PR and lacked the time. If someone has the time to figure out a gh-action to do so, we could add CIs and a doc build easily. |
@mscheltienne I pushed a couple of commits, I've been testing locally with:
on latest MNE |
... we should wait for the |
Okay a couple more commits, now everything works on my system with the full dataset! If anyone else wants to test you can download the ~27GB version then test with: $ ./tools/get_testing_data.sh
$ MNE_HCP_TESTING_PATH=~/mne-hcp-data/HCP MNE_HCP_TEST_DECIM=1 pytest -rfEXs --cov-report= --tb=short --durations 30 -v --cov=hcp --cov-report xml hcp |
@dengemann any chance you could look? Without this dataset I'm not sure we can do much here maintenance-wise 😬 |
I think we should add a banner message saying that this code is now
unmaintained. Nobody understands it or has time to dig.
… Message ID: ***@***.***>
|
This package is barely maintained, but I still see a question on the forum from time to time; or someone who directly contacts me with questions regarding this package.
This PR fixes the deprecated imports, fix styles, updates the packaging,..
WIP