-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add show hide menu with freesurfer atlas #27
Conversation
@larsoner do you have a minute to point me in the right direction for how to fix these CI errors? looks like they were solved on |
I would suggest to update pinning like mne-tools/mne-python#12580 |
Ok for notes about this PR: I went to add show/hide for the head and I felt like there were a lot of buttons in a lot of different places and I looked at the text and a lot of those buttons were show/hide (max intensity projection, local maxima, brain slices) so I consolidated them into a show/hide menu while adding the show/hide head functionality. That will play really well with #10 which adds a lot of other elements that it will be nice to show/hide separately. Lastly, I wrapped into this PR showing the anatomical segmentation atlas because that's also very helpful to see relative to the contacts and also needs show/hide functionality. It looks really good, super useful I think, especially if you want to make a figure of one contact's location or really understand the positioning of that contact. |
Ok, just had to fix the style everything else passed. If you want to give it a quick spin, here's some scripts that aren't too heavy
|
Ok to merge? |
Fixes #26