-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ADB to take screenshots of android devices #186
Open
r1sim
wants to merge
13
commits into
mmcc007:master
Choose a base branch
from
r1sim:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1sim
changed the title
Use ADB to take screenshots of android devices
WIP: Use ADB to take screenshots of android devices
Feb 9, 2020
r1sim
changed the title
WIP: Use ADB to take screenshots of android devices
Use ADB to take screenshots of android devices
Feb 9, 2020
Compatibility with Dart 2.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ADB screenshots for android devices as discussed in #175
Main Changes:
adb_path
&adb_device_id
toconfig.screenshotsEnv
config.screenshotsEnv
are set and if thedevice_type
is android. If that is the case it will attempt to take screenshots using adb. It will use FlutterDriver to take the screenshots if the adb method fails for whatever reason..adb.png
or.driver.png
so the image processor knows how to process them. (Add Navbar or not)This works well with my setup. If it works as well for everyone else we could maybe think about dropping FlutterDriver support for android devices. This would make it much easier to add new devices because we would no longer need to add a statusbar and navbar for every resolution. The only downside of this would be that demo mode requires android 6.0.