fix for Arduino > 3.1.0 #51
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
mlesniew
force-pushed
the
arduino-3.1.0
branch
5 times, most recently
from
6fab5ba
to
7ae9f3b
Compare
This adds two new method overrides for classes inheriting from ::Client * connect(IPAddress ip, uint16_t port, int32_t timeout) * connect(const char * host, uint16_t port, int32_t timeout) Changes also include a CI update to build tests with both pioarduino and the official platformio esp32 platform.
mlesniew
force-pushed
the
arduino-3.1.0
branch
from
7ae9f3b
to
df9d7cb
Compare
|
|
I have polished the changes a bit and added a CI config to build examples with the recent release of pioarduino too. Unfortunately, this revealed that PicoWebsocket was incompatible, so changes were required there too, see: mlesniew/PicoWebsocket@1664f81 But finally I got it working in all configurations and in the CI. Thanks for the contribution! |
client:connect(IPAddress ip, uint16_t port, int32_t timeout) and connect(const char * host, uint16_t port, int32_t timeout)
were added to Client in 3.1.x - handle those
see https://github.com/mhaberler/aptest for a demo using pioarduino 3.0.7 and 3.1.0-rc3
see https://discord.com/channels/1263397951829708871/1268903464700739706 for the release history