Add Python 3 support #10

jonyesno · 2020-08-04T05:20:00Z

This MR:

encodes/decodes strings to/from bytes when talking to the HAProxy socket
tweaks the try … except syntax

both of which make the plugin work under Python 3.

This addresses the following logged exceptions:

Unhandled python exception in importing module: SyntaxError: invalid syntax
Unhandled python exception in read callback: TypeError: a bytes-like object is required, not 'str'
Unhandled python exception in read callback: TypeError: must be str, not bytes

Disclaimer: my Python skills are very limited, but this fixed it for me.

Python 3 distinguishes between Unicode `str`ings and byte strings. The socket is expecting bytes, and we've dealing with `str`ings internally so we need to convert in each direction. This fixes the following problems: ``` Unhandled python exception in read callback: TypeError: a bytes-like object is required, not 'str' Unhandled python exception in read callback: TypeError: must be str, not bytes ```

graingert · 2021-11-30T09:41:27Z

haproxy.py

    result = ''
    buf = ''
    buf = s.recv(RECV_SIZE)
    while buf:
-      result += buf
+      result += buf.decode()


you need to use an incremental decoder, or decode the whole value at once in return result.decode()

jonyesno added 2 commits August 4, 2020 15:07

fix except syntax for Python 3

b49f20f

graingert reviewed Nov 30, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python 3 support #10

Add Python 3 support #10

jonyesno commented Aug 4, 2020

graingert Nov 30, 2021 •

edited

Loading

Add Python 3 support #10

Are you sure you want to change the base?

Add Python 3 support #10

Conversation

jonyesno commented Aug 4, 2020

graingert Nov 30, 2021 • edited Loading

Choose a reason for hiding this comment

graingert Nov 30, 2021 •

edited

Loading