Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes:
ensureIdAndThatItDoesNotExist
toslick.dataview.js
, and call it whenever we add a new row. Without this function, many rows will be assigned to the same key in theidxById
map (so they will overwrite each other), andidxById
will only contain the idx of the most recently added row with thatid
. This screws other things up; e.g., upon a call todeleteItem
, only the most recently added row with thisid
will be deleted. Better to fail loudly the first time a duplicateid
is added, I believe.