PATCH api/users 기능 추가 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndaemy
requested changes
Aug 5, 2023
src/api/users/users.service.ts
Outdated
| return this.prismaService.user.findUnique({ | ||
| where: { username }, | ||
| }); | ||
| } | ||
|
|
||
| update(id: string, updateUserDto: UpdateUserDto) { | ||
| return `This action updates a #${id} user`; | ||
| async isDateOnlyFormatValid(dateOnly: boolean, dates: string[]) { |
There was a problem hiding this comment.
- 얘는 private method 로 만들면 좋을 것 같고,
- private method 는 맨 위든 맨 밑이든 한 쪽으로 몰면 좋을 것 같아요!
|
코드 리뷰 기반하여 수정 완료했습니다.
|
ndaemy
approved these changes
Aug 8, 2023
| @@ -56,7 +70,7 @@ export class UsersService { | |||
| if (badRequestErros.length > 0) { | |||
| throw new BadRequestException(badRequestErros); | |||
| } | |||
|
|
|||
| console.log(roomCode); | |||
There was a problem hiding this comment.
나중에 시간 되면 이런 테스트 코드는 삭제시켜주시면 좋을듯!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATCH api/users 기능 추가하였습니다.
요청 형식은
query params
roomCode
Body
username
dateOnly
dates
입니다.