dateOnly, username 요청값으로 받아오지 않도록 수정 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndaemy
reviewed
Aug 23, 2023
src/api/rooms/rooms.service.ts
Outdated
Comment on lines
24
to
32
| async getRoomInfo(code: string): Promise<boolean> { | ||
| const roomInfo = await this.prismaService.room.findUnique({ | ||
| where: { code }, | ||
| }); | ||
| //만약 방이 없다면 예외처리를 어떻게 해야 할까요?? | ||
| const dateOnly = roomInfo.dateOnly; | ||
| return dateOnly; | ||
| } | ||
|
|
There was a problem hiding this comment.
이건 이미 존재하는 findOne 을 써도 괜찮았을 것 같은데, 별도로 선언한 특별한 이유가 있는건가요?
There was a problem hiding this comment.
?????????? 그렇네요???????
findone으로 사용하는걸로 수정할게용
src/api/users/users.service.ts
Outdated
| @@ -95,14 +86,17 @@ export class UsersService { | |||
| return token; | |||
| } | |||
|
|
|||
| async update(roomCode: string, updateUserDto: UpdateUserDto) { | |||
| async update( | |||
| userInfoFromTk: User, | |||
There was a problem hiding this comment.
요거 네이밍은 아예 줄이거나 아예 늘리거나 하면 좋을 것 같아요! 한 번에 무슨 뜻인지 잘 와닿지 않아서요!
- user
- userInfoFromToken
|
아 그리고 PR 이름도 바꿔주세요! |
kMinsAlgorithm
changed the title
|
다시 재수정 했습니다. 확인 부탁드립니당 @ndaemy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mjulikelion11th.slack.com/archives/C053JFTFV5J/p1692633946592789
이 피드백 토대로 수정 완료 했습니다.
dateOnly는 DB를 통해, username은 토큰을 통해 받아오도록 수정했습니다.