webmail: if we don't have loaded account settings yet, abort loading …

…the popup after showing an error that the settings aren't available yet missing returning/throwing error. based on screenshot with unhandled js error in issue #218 by mgkirs
mjl- · Oct 10, 2024 · 0430572 · 0430572
1 parent 0fbf241
commit 0430572
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/webmail/webmail.js b/webmail/webmail.js
@@ -2391,7 +2391,7 @@ const cmdSettings = async () => {
 	let showAddressSecurity;
 	let showHTML;
 	if (!accountSettings) {
-		window.alert('No account settings fetched yet.');
+		throw new Error('No account settings fetched yet.');
 	}
 	const remove = popup(css('popupSettings', { padding: '1em 1em 2em 1em', minWidth: '30em' }), dom.h1('Settings'), dom.form(async function submit(e) {
 		e.preventDefault();

diff --git a/webmail/webmail.ts b/webmail/webmail.ts
@@ -1117,7 +1117,7 @@ const cmdSettings = async () => {
 	let showHTML: HTMLInputElement
 
 	if (!accountSettings) {
-		window.alert('No account settings fetched yet.')
+		throw new Error('No account settings fetched yet.')
 	}
 
 	const remove = popup(