Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shift + play midi data for ddj-flx4 controller mapping #13857

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Aquassaut
Copy link
Contributor

Hi,

After the issue #13813 and the resolving PR #13815, I found another controller mapping issue for the DDJ-flx4, whereby the mapping expects midino 0x47 for shift + play, while the device sends 0x0E.

I think this stems from the fact that the very similar DDJ-400, from which the mapping was modified to create the flx4 mapping, does send 0x47. I think it fell through the cracks because the feature doesn't seem to be used all that often, I myself discovered the issue because I was trying to remap it to another behavior.

For reference, here's the DDJ-400 midi messages document and here the DDJ-FLX4 midi messages document. More conveniently here are the screenshots outlining the difference:

DDJ-FLX4
ddj-flx4-shift-play
DDJ-400
ddj-400-shift-play

Since last time, you guys asked me to base the PR off of branch 2.4, I'm doing the same thing here, let me know if I should rebase it off of another one or if anything else should be done.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for catching this. You're totally right with your conclusion that this was copied from the DDJ-400 and slipped through the cracks. LGTM.

@Swiftb0y Swiftb0y merged commit 775d369 into mixxxdj:2.4 Nov 9, 2024
14 checks passed
@Swiftb0y
Copy link
Member

Swiftb0y commented Nov 9, 2024

fyi, in the future I recommend you create a separate feature branch. Without you're bound to run into trouble if you want to sync your own 2.4 branch with our upstream one.

@Aquassaut
Copy link
Contributor Author

Thanks I'll make sure I do for anything more consequent. In this case I was not really that worried about the hard reset/force push on my end, but you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants