Fix shift + play midi data for ddj-flx4 controller mapping #13857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After the issue #13813 and the resolving PR #13815, I found another controller mapping issue for the DDJ-flx4, whereby the mapping expects midino 0x47 for shift + play, while the device sends 0x0E.
I think this stems from the fact that the very similar DDJ-400, from which the mapping was modified to create the flx4 mapping, does send 0x47. I think it fell through the cracks because the feature doesn't seem to be used all that often, I myself discovered the issue because I was trying to remap it to another behavior.
For reference, here's the DDJ-400 midi messages document and here the DDJ-FLX4 midi messages document. More conveniently here are the screenshots outlining the difference:
DDJ-FLX4
DDJ-400
Since last time, you guys asked me to base the PR off of branch 2.4, I'm doing the same thing here, let me know if I should rebase it off of another one or if anything else should be done.