Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clazy-strict-iterators warning #13855

Closed

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Nov 8, 2024

Lets see if CI approves of this Qt 6.1 code. If not I'll implement the less pretty alternative. Doesn't work, less pretty alternative it is.

@Swiftb0y Swiftb0y force-pushed the fix/2.5-clazy-ci-const-iterator branch from b33f076 to 76e4a40 Compare November 8, 2024 22:45
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Waiting for CI.

@daschuer
Copy link
Member

daschuer commented Nov 8, 2024

I was already working on a fix here: #13856

@Holzhaus
Copy link
Member

Holzhaus commented Nov 8, 2024

@daschuer it's the other way around, this PR is 10 minutes older.

@daschuer
Copy link
Member

daschuer commented Nov 9, 2024

Yes, right. I did a CI run in my private repro first. After this was successful I have issued the PR afterthis one.

I don't mind which one is merged. Current state: this is failing, #13856 is green.

@Holzhaus Holzhaus added the duplicate This issue is a duplicate of or superseded by another issue. label Nov 9, 2024
@Holzhaus Holzhaus closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate of or superseded by another issue. library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants