Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ValueTransformer and WBaseWidget #13853

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor ValueTransformer and WBaseWidget #13853

wants to merge 10 commits into from

Commits on Nov 9, 2024

  1. refactor: replace QScopedTimer with unique_ptr

    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    1c5b48f View commit details
    Browse the repository at this point in the history

  2. refactor: use parented_ptr instead of raw one

    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    594c428 View commit details
    Browse the repository at this point in the history

  3. refactor: slim down valuetransformer.h and auto memory management

    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    b369cea View commit details
    Browse the repository at this point in the history

  4. refactor: eliminate naked news from WHotcueButton

    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    4c4384e View commit details
    Browse the repository at this point in the history

  5. refactor: modernize and deplicate WPushButtonTest

    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    21d4d9a View commit details
    Browse the repository at this point in the history

  6. refactor: Improve generic-y of WBaseWidget-related code 

    This is prep for the follow up commit to make it lighter.
    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    9163b08 View commit details
    Browse the repository at this point in the history

  7. refactor: automate memory management in WBaseWidget

    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    78a7cc4 View commit details
    Browse the repository at this point in the history

  8. refactor: move unique_ptr::get() to improve usability 

    This ensures that if a connection is a DisplayConnection then
it is also added to the other connections. This improves memory
safety as well as usability because it makes it impossible to
accidentally set a connection as DisplayConnection that is not
tracked by the WBaseWidget.
    @Swiftb0y
    Swiftb0y committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    2c78d23 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. fixup! refactor: move unique_ptr::get() to improve usability

    @Swiftb0y
    Swiftb0y committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    abf5fe6 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. fixup! refactor: move unique_ptr::get() to improve usability

    @Swiftb0y
    Swiftb0y committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    66aef70 View commit details
    Browse the repository at this point in the history