Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix pre-commit on F41 and update remaining dependencies #13843

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Nov 6, 2024

Edit: this also updates the internal dependencies to be reasonably up-to-date enough to even successfully install. otherwise lxml doesn't compile on Fedora 41. Essentially without this PR, developing on Fedora is broken and thus we should merge this reasonably quickly.

newer Pre-commit versions issue warnings about our config using outdated stage names. This fixes to be complaint to pre-commit v4.

[WARNING] hook id eslint uses deprecated stage names (commit) which will be removed in a future version. run: pre-commit migrate-config to automatically fix this.

newer Pre-commit versions issue warnings about our config using
outdated stage names. This fixes to be complaint to pre-commit v4.
@JoergAtGithub
Copy link
Member

There is still one of these warnings left, but I don't see why.

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Nov 7, 2024

I think thats because we're currently targeting and old version of https://github.com/pre-commit/pre-commit-hooks that also does not yet have its config migrated. a pre-commit autoupdate would likely fix that. Should I include that here?

This primarily fixes issues compiling lxml on newer treesitter
versions (required for Fedora 41)
@Swiftb0y Swiftb0y changed the title chore: pre-commit migrate-config chore: Fix pre-commit on F41 and update remaining dependencies Nov 7, 2024
@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 704e2d4 into mixxxdj:2.4 Nov 7, 2024
14 checks passed
@Swiftb0y
Copy link
Member Author

Swiftb0y commented Nov 8, 2024

Thank you for the quick merge.

@Swiftb0y Swiftb0y deleted the chore/upgrade-pre-commit branch November 8, 2024 09:57
@JoergAtGithub
Copy link
Member

I needed to call pip install pre-commit --upgrade to get pre-commit working again. As my installed version did not know the command autoupdate and failed therefore.

@Swiftb0y
Copy link
Member Author

Good to know, your pre-commit version must've been ancient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants