(fix) Sound preferences: don't set m_settingsModified in update slots #13450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
m_settingsModified
is set inDlgPrefSound::slotUpdate()
which will cause a sound pause when pressing Apply in any pref page, becauseDlgPrefSound::slotApply()
would reapply the current (unchanged) sound config.#13070 (comment)
Fixed by moving the keylock dual-threading checkbox update to a dedicated method and call then when necessary.
@acolombier please check if I got everything right.