Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations source copy check #13419

Open
wants to merge 10 commits into
base: 2.4
Choose a base branch
from
+645 −4
Open

Translations source copy check #13419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e1e7ef
Add a pre-commit hook to check for copied source texts
daschuer Jun 27, 2024
5879a40
Integrate it to .pre-commit-config.yaml
daschuer Jun 30, 2024
65e24f5
use an allow list for intended source copies
daschuer Jun 30, 2024
223b736
for English languages all source copies are allowed
daschuer Jun 30, 2024
255c7d6
Add exception handling and prevent reformatting of ts files and disab…
daschuer Jun 30, 2024
17b9206
Add initial source_copy_allow_list that contains all alowed copied/Un…
daschuer Jul 7, 2024
cd83745
Transition to a tsv based allow list
daschuer Oct 24, 2024
dcb606b
Use tsv files for the allow list
daschuer Oct 27, 2024
0dee602
Don't exclude *.d.ts files
daschuer Oct 27, 2024
233777b
Allow a wild card at any position in laguage strings. deduplictaed th…
daschuer Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
# because it won't prevent catching other, unrelated issues.

# _anlz.h/_pdb.h: Header files generated by Kaitai Struct
exclude: ^(lib/|src/test/.*data/).*|res/controllers/lodash\.mixxx\.js|res/translations/.*\.ts|src/.*_(anlz|pdb)\.h$
exclude: ^(lib/|src/test/.*data/).*|res/controllers/lodash\.mixxx\.js|src/.*_(anlz|pdb)\.h$
minimum_pre_commit_version: 2.21.0
default_language_version:
python: python3
Expand All @@ -43,10 +43,10 @@ repos:
- id: check-yaml
exclude: ^\.clang-format$
- id: end-of-file-fixer
exclude: ^.*UTF-8-BOM.txt$
exclude: ^.*(UTF-8-BOM\.txt|\.ts)$
- id: mixed-line-ending
- id: trailing-whitespace
exclude: \.(c|cc|cxx|cpp|d.ts|frag|glsl|h|hpp|hxx|ih|ispc|ipp|java|js|m|mm|proto|vert)$
exclude: \.(c|cc|cxx|cpp|ts|frag|glsl|h|hpp|hxx|ih|ispc|ipp|java|js|m|mm|proto|tsv|vert)$
- id: no-commit-to-branch
# protect main and any branch that has a semver-like name
args: [-b, main, -p, '^\d+\.\d+(?:\.\d+)?$']
Expand All @@ -64,7 +64,7 @@ repos:
"\\W(?:m_p*(?=[A-Z])|m_(?=\\w)|pp*(?=[A-Z])|k(?=[A-Z])|s_(?=\\w))",
--write-changes,
]
exclude: ^(packaging/wix/LICENSE.rtf.in|src/dialog/dlgabout\.cpp|.*\.(?:pot?|(?<!d\.)ts|wxl|svg))$
exclude: ^(packaging\/wix\/LICENSE.rtf.in|src\/dialog\/dlgabout\.cpp|.*\.(?:pot?|(?<!\.d\.)ts|wxl|svg))$
- repo: https://github.com/pre-commit/mirrors-eslint
rev: v8.48.0
hooks:
Expand All @@ -81,6 +81,7 @@ repos:
- "@typescript-eslint/eslint-plugin"
- "@typescript-eslint/parser"
- eslint-plugin-diff@^2.0.3
exclude: ^.*\.(?<!\.d\.)ts$
- repo: local
hooks:
- id: clang-format
Expand Down Expand Up @@ -170,3 +171,15 @@ repos:
- Markdown==3.4.1
types: [text]
files: ^(CHANGELOG\.md|res/linux/org\.mixxx\.Mixxx\.metainfo.xml)$
- id: ts-source-copy
name: ts-source-copy
description: "Find translations literaly copied form the source language"
daschuer marked this conversation as resolved.
Show resolved Hide resolved
entry: python tools/ts_source_copy_check.py
stages:
- commit
- manual
require_serial: true
language: python
additional_dependencies:
- lxml==4.9.3
files: ^(res/translations/.*\.ts)$
Loading
Loading