Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Library: repair Del hotkey in sidebar, add Clear Queue action to AutoDJ, add hotkeys #13364

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 12, 2024

Fixes #13361

  1. restore Del hotkey (delete playlist / crate)
  2. to not drop the 'clear' function I added a 'Clear Queue' menu action to the AutoDJ root view incl. a confirmatio dialog
  3. show Del hotkey in AutoDJ -> Clear and 'Remove crate/playlist' actions

Alternatively, we pick only the fix for 2.5 and the new action goes to 2.6

@ronso0 ronso0 requested a review from m0dB June 12, 2024 12:31
@ronso0 ronso0 force-pushed the lib-sidebar-del-hotkey-autodj branch from 762e243 to a87712f Compare June 12, 2024 12:32
@ronso0 ronso0 added this to the 2.5.0 milestone Jun 12, 2024
@ronso0 ronso0 added the keyboard label Aug 5, 2024
@ronso0
Copy link
Member Author

ronso0 commented Aug 5, 2024

ding dong
Is really no one else is bothered by that regression?

We're slowly approaching the 2.5 release so wdyt about this?

Alternatively, we pick only the fix for 2.5 and the new action goes to 2.6

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just realized that I had a pending minor review comment. Here is it.

src/library/autodj/autodjfeature.cpp Outdated Show resolved Hide resolved
@ronso0 ronso0 marked this pull request as draft August 6, 2024 09:26
@m0dB
Copy link
Contributor

m0dB commented Aug 6, 2024

Sorry for not being very responsive, I am travelling. LGTM but not merging as there is a pre-commit issue.

@ronso0 ronso0 force-pushed the lib-sidebar-del-hotkey-autodj branch from 91c13c0 to a377746 Compare August 6, 2024 09:53
@ronso0 ronso0 marked this pull request as ready for review August 6, 2024 10:10
@ronso0
Copy link
Member Author

ronso0 commented Aug 6, 2024

Thanks.

LGTM but not merging as there is a pre-commit issue.

I guess that was from the tr code suggestions, fixed by merging that commit as fixup.
Ready to roll!

@m0dB m0dB merged commit ba773d0 into mixxxdj:2.5 Aug 6, 2024
13 checks passed
@ronso0 ronso0 deleted the lib-sidebar-del-hotkey-autodj branch August 6, 2024 11:25
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/mixxx that referenced this pull request Aug 23, 2024
This fits in nicely with the "Clear Auto DJ Queue" action
introduced by mixxxdj#13364.
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/mixxx that referenced this pull request Aug 24, 2024
This fits in nicely with the "Clear Auto DJ Queue" action
introduced by mixxxdj#13364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Del key in sidebar doesn't trigger crate/playlist delete dialog anymore
3 participants