Track menu: add star rating #12700
Merged
Track menu: add star rating #12700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
commented
Jan 30, 2024
ronso0
force-pushed
the
track-menu-stars
branch
from
90f73a5
to
718e709
Compare
ronso0
force-pushed
the
track-menu-stars
branch
3 times, most recently
from
cde2886
to
a4f7ed1
Compare
|
Oh wait, why the submenu? |
ronso0
force-pushed
the
track-menu-stars
branch
2 times, most recently
from
490eb6e
to
9b49ba0
Compare
|
This can be added in a 2.4 point release or in 2.5, I don't mind. |
ronso0
force-pushed
the
track-menu-stars
branch
from
9b49ba0
to
53a0e80
Compare
ronso0
force-pushed
the
track-menu-stars
branch
from
53a0e80
to
9fbffb4
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the coffee break projects to keep the balance between chore and fun/challenges.
All building blocks are already there, and working on top of #12648 this was easy. Styling was a no-brainer unexpectedly : )
Works as desired. Draft until #12648 is merged.
based on #12648
Fixes #10652
Note: I did intentionally not define a hover effect. It seems that can only be applied to the star rating (not the entire row), and since the rating is surrounded by submenu actions that expand on hover, the star hover effect kicks in only after those submenus disappeared and the pointer is moved (unlike with other actions/submenus where the hover style is applied instantly).