feat(controllers): add new controller mapping for Numark NS6II #11075
Conversation
Swiftb0y
force-pushed
the
numark-ns6ii
branch
3 times, most recently
from
1f3330e
to
6f16bba
Compare
|
tests are failing because of the EffectUnits. I guess I'll have to redo them when I find the time. Works locally so far. |
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Swiftb0y
force-pushed
the
numark-ns6ii
branch
2 times, most recently
from
7872f2b
to
fccd316
Compare
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
|
Ah yes, good old stale. I have had and used this controller for about 5 years now, one day I'll get around to polishing the mapping enough for merge. Still, a surface-level review in the meantime would be appreciated. |
github-actions
bot
removed
the
stale
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
There was a problem hiding this comment.
Hard to review without the device to test. but it is looking good overall. Also I'm sure that if you've been using it this long, you probably had a chance to polish most of the small bug lying around :)
Some comment cruft here and there that might be worth removing or documenting if useful for alternate behaviours (note that if the latter, you might want to consider the controller settings).
Did you have a chance to prepare the manual for that?
|
I'll try to give this another look and ping you when I think its ready. Thanks for the review. |
|
@acolombier please re-review ;) |
Swiftb0y
removed
the
stale
| @@ -1,4 +1,6 @@ | |||
|
|
|||
| type MidiInputHandler = (channel: number, control: number, value:number, status:number, group:string) => void; | |||
|
|
|||
There was a problem hiding this comment.
I can't spot the place, where this type is defined in our API. Is this a mapping specific type, that doesn't belong to the API?
There was a problem hiding this comment.
Its the type our input handlers are expected to be https://github.com/mixxxdj/mixxx/wiki/midi%20scripting#midi-input-handling-functions
|
friendly ping... ;) |
| // grey could be an alternative as well as a backlight color. | ||
| off: NS6II.USE_BUTTON_BACKLIGHT ? NS6II.PAD_COLORS.RED.DIMMER : NS6II.PAD_COLORS.OFF, |
There was a problem hiding this comment.
Could it be worth adding a dynamic setting for that?
There was a problem hiding this comment.
yes, I'll add that as a follow up, but I wanted to keep this branch targetted at 2.4
| }); | ||
| this.scratch = new components.Button({ | ||
| midi: [0x90 + channelOffset, 0x07], | ||
| // shift: [0x90+channelOffset,0x46] |
There was a problem hiding this comment.
Can this be removed as this is redundant with line 409/414?
There was a problem hiding this comment.
technically yes, but I would've preferred this to stay here instead of having it buried in the implementation.
| this.parameterLeft = new components.Button({ | ||
| midi: [0x90, 0x28], | ||
| unshift: function() { | ||
| // TODO change hotcue page |
There was a problem hiding this comment.
Is this outstanding? Or should it be removed?
There was a problem hiding this comment.
nah, its technically outstanding, but I really didn't want to bother implementing that because components.HotcueButton is not setup for that.
| this.parameterRight = new components.Button({ | ||
| midi: [0x90, 0x29], | ||
| unshift: function() { | ||
| // TODO change hotcue page |
Swiftb0y
force-pushed
the
numark-ns6ii
branch
from
88f6b73
to
88b88a0
Compare
Manual still TODOmanual PR