Full Ableton Link support #10999

JoergAtGithub · 2022-10-24T20:14:03Z

Based on the old PR #3783 from @spensbot, I created a new PR with Ableton Link support for Main.
Currently the GUI controls exist only for Latenight:

The LINK-Button enables/disables the Link session. The number right to it shows the number of connected Link peers.
It syncronizes Tempo and Beat-Position (Phase). In Ableton Link all peers are equal, there is no leader. Therefore syncronization is always bidirectional.

In this Implementation, it syncs the Mixxx-Sync-Leader with the other peers. Means, it works only if the Crown-Button for a deck and the new LINK-Button are active.

I tested this with the official LinkHut-App of the Ableton Link package and with the Android App "G-Stomper Rythm", which is a free Drummachine, but with advertizing. A very cool Ableton Link software is also the music visualisation and lighting software from spensbot: https://captivatesynth.com/

Test Plan
Any Ableton Link software, should pass the following test plan:
https://github.com/Ableton/link/blob/master/TEST-PLAN.md

To install the official Linkhut reference tools used in the test plan, you can use VCPKG: ./vcpkg install ableton[hut,hutsilent]

Closes #8650

On startup, Mixxx will enable link and join the active link session We have much to do for Mixxx to become a link-compatible app Basically, Mixxx needs to respond to & update the active link session to synchronize bpm & phase

Remove the ableton link submodule

Change logging to standard Qt commands Use Doxygen style comments in abletonlink.h

…d the speaker output

…rsion of 3.05 Disabled system AbletonLink for Debian, because this package is broken in Ubuntu 20.04

Moved debug code from header to cpp

…hange

src/engine/sync/abletonlink.h

…k) as clock reference

Refactored various methods in `AbletonLink` to use `auto` and `const auto` for improved readability and simplicity. Updated floating-point literals to use `1.0` instead of `1.` for clarity and consistency.

jonahclarsen · 2024-09-05T03:25:53Z

Just want to say I'm super stoked for this and thankful for all your effort!

CMakeLists.txt

Swiftb0y · 2024-09-06T18:09:36Z

src/engine/sync/abletonlink.cpp

+    m_pNumLinkPeers->setReadOnly();
+    m_pNumLinkPeers->forceSet(0);
+
+    // The callback is invoked on a Link - managed thread.
+    // The callback is the only entity, which access m_pNumLinkPeers
+    m_pLink->setNumPeersCallback([this](std::size_t numPeers) {
+        m_pNumLinkPeers->forceSet(numPeers);
+    });


then make it a member of the lambda instead.

Suggested change

m_pNumLinkPeers->setReadOnly();

m_pNumLinkPeers->forceSet(0);

// The callback is invoked on a Link - managed thread.

// The callback is the only entity, which access m_pNumLinkPeers

m_pLink->setNumPeersCallback([this](std::size_t numPeers) {

m_pNumLinkPeers->forceSet(numPeers);

});

// The callback is invoked on a Link - managed thread.

m_pLink->setNumPeersCallback([ControlObject numLinkPeers = []{

ControlObject numLinkPeers(ConfigKey(group, numPeers));

numLinkPeers.setReadOnly();

numLinkPeers.forceSet(0);

return numLinkPeers;

}()](std::size_t numPeers) {

numLinkPeers.forceSet(numPeers);

});

The proposed code does not compile, as it does not match to the declaration in the headers of Link.

that does not make sense. Can you post the error?

Thanks. looks like a syntax issue. I'll figure it out.

init captures don't support explicit type declarations. Try this:

Suggested change

m_pNumLinkPeers->setReadOnly();

m_pNumLinkPeers->forceSet(0);

// The callback is invoked on a Link - managed thread.

// The callback is the only entity, which access m_pNumLinkPeers

m_pLink->setNumPeersCallback([this](std::size_t numPeers) {

m_pNumLinkPeers->forceSet(numPeers);

});

// The callback is invoked on a Link - managed thread.

m_pLink->setNumPeersCallback([numLinkPeers = []{

ControlObject numLinkPeers(ConfigKey(group, numPeers));

numLinkPeers.setReadOnly();

numLinkPeers.forceSet(0);

return numLinkPeers;

}()](std::size_t numPeers) {

numLinkPeers.forceSet(numPeers);

});

This doesn't work too:

[64/126] Building CXX object CMakeFiles\mixxx-lib.dir\src\engine\sync\abletonlink.cpp.obj FAILED: CMakeFiles/mixxx-lib.dir/src/engine/sync/abletonlink.cpp.obj C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.341\bin\Hostx64\x64\cl.exe /nologo /TP -DAMD64 -DDJINTEROP_SOURCE -DLINK_PLATFORM_WINDOWS=1 -DMIXXX_BUILD_RELEASE -DMIXXX_DEBUG_ASSERTIONS_ENABLED -DMIXXX_DEBUG_ASSERTIONS_FATAL -DMIXXX_USE_QML -DMIXXX_USE_QOPENGL -DNOMINMAX -DPROTOBUF_USE_DLLS -DQT_CONCURRENT_LIB -DQT_CORE5COMPAT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_LABSQMLMODELS_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_QMLINTEGRATION_LIB -DQT_QMLMODELS_LIB -DQT_QMLWORKERSCRIPT_LIB -DQT_QML_LIB -DQT_QUICKCONTROLS2IMPL_LIB -DQT_QUICKCONTROLS2_LIB -DQT_QUICKLAYOUTS_LIB -DQT_QUICKSHAPES_LIB -DQT_QUICKTEMPLATES2_LIB -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_SHADERTOOLS_LIB -DQT_SQL_LIB -DQT_SVGWIDGETS_LIB -DQT_SVG_LIB -DQT_TABLET_SUPPORT -DQT_TESTCASE_BUILDDIR=\"D:/mixxx-main-pr-test/build/x64__portable\" -DQT_TESTCASE_SOURCEDIR=\"D:/mixxx-main-pr-test\" -DQT_TESTLIB_LIB -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -DSFC_SUPPORTS_SET_COMPRESSION_LEVEL -DUNICODE -DWIN32 -DWIN32_LEAN_AND_MEAN -DWIN64 -DWINVER=0x0601 -D_ATL_MIN_CRT -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING -D_UNICODE -D_USE_MATH_DEFINES -D_WIN32_WINNT=0x0601 -D_WIN64 -D__BATTERY__ -D__BROADCAST__ -D__BULK__ -D__ENGINEPRIME__ -D__FFMPEG__ -D__HID__ -D__HSS1394__ -D__LILV__ -D__MAD__ -D__MEDIAFOUNDATION__ -D__MODPLUG__ -D__OPUS__ -D__PORTMIDI__ -D__QTKEYCHAIN__ -D__RUBBERBAND__ -D__SNDFILE__ -D__SQLITE3__ -D__SSE2__ -D__SSE__ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STEM__ -D__VINYLCONTROL__ -D__WINDOWS__ -D__WV__ -ID:\mixxx-main-pr-test\build\x64__portable\mixxx-lib_autogen\include -ID:\mixxx-main-pr-test\src -ID:\mixxx-main-pr-test\build\x64__portable\src -external:ID:\mixxx-main-pr-test\lib\fidlib -external:ID:\mixxx-main-pr-test\lib\portaudio -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include -external:ID:\mixxx-main-pr-test\lib\rigtorp\SPSCQueue\include -external:ID:\mixxx-main-pr-test\lib\replaygain -external:ID:\mixxx-main-pr-test\lib\reverb -external:ID:\mixxx-main-pr-test\lib\libshout-idjc\include -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\share\ableton-link\..\..\include\ableton -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\share\asio\..\..\include -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\djinterop -external:ID:\mixxx-main-pr-test\lib\rekordbox-metadata -external:ID:\mixxx-main-pr-test\lib\kaitai -external:ID:\mixxx-main-pr-test\lib\mp3guessenc-0.27.4 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtConcurrent -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\share\Qt6\mkspecs\win32-msvc -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtGui -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtNetwork -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtOpenGL -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtPrintSupport -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtWidgets -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQml -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlIntegration -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtSql -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtSvg -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtTest -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtXml -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtShaderTools -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtSvgWidgets -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore5Compat -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuick -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlModels -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtLabsQmlModels -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlModels\6.5.3 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlModels\6.5.3\QtQmlModels -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore\6.5.3 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore\6.5.3\QtCore -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQml\6.5.3 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQml\6.5.3\QtQml -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickControls2 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickControls2Impl -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickLayouts -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtGui\6.5.3 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtGui\6.5.3\QtGui -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuick\6.5.3 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuick\6.5.3\QtQuick -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickShapes -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickShapes\6.5.3 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickShapes\6.5.3\QtQuickShapes -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickTemplates2 -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickWidgets -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlWorkerScript -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\taglib -external:ID:\mixxx-main-pr-test\lib\qm-dsp -external:ID:\mixxx-main-pr-test\lib\qm-dsp\include -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\opus -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\hidapi -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\libusb-1.0 -external:ID:\mixxx-main-pr-test\lib\xwax -external:ID:\mixxx-main-pr-test\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\wavpack -external:W0 /DWIN32 /D_WINDOWS /EHsc /Zc:__cplusplus /Zc:inline /Z7 /O2 /DNDEBUG -std:c++20 -MD /UTF8 /fp:fast /Gy /W3 /wd4200 -DPA_USE_JACK=1 -DPA_USE_ASIO=1 -DPA_USE_DS=1 -DPA_USE_WMME=1 -DPA_USE_WASAPI=1 -DPA_USE_WDMKS=1 -Zc:__cplusplus -permissive- -utf-8 /YuD:/mixxx-main-pr-test/build/x64__portable/CMakeFiles/mixxx-lib.dir/cmake_pch.hxx /FpD:/mixxx-main-pr-test/build/x64__portable/CMakeFiles/mixxx-lib.dir/./cmake_pch.cxx.pch /FID:/mixxx-main-pr-test/build/x64__portable/CMakeFiles/mixxx-lib.dir/cmake_pch.hxx /showIncludes /FoCMakeFiles\mixxx-lib.dir\src\engine\sync\abletonlink.cpp.obj /Fdmixxx-lib.dir\mixxx-lib.pdb /FS -c D:\mixxx-main-pr-test\src\engine\sync\abletonlink.cpp D:\mixxx-main-pr-test\src\engine\sync\abletonlink.cpp(40): error C3493: 'group' cannot be implicitly captured because no default capture mode has been specified D:\mixxx-main-pr-test\src\engine\sync\abletonlink.cpp(40): error C2065: 'numPeers': undeclared identifier D:\mixxx-main-pr-test\src\engine\sync\abletonlink.cpp(45): error C2662: 'void ControlObject::forceSet(double)': cannot convert 'this' pointer from 'const ControlObject' to 'ControlObject &' D:\mixxx-main-pr-test\src\engine\sync\abletonlink.cpp(45): note: Conversion loses qualifiers D:\mixxx-main-pr-test\src\control/controlobject.h(112): note: see declaration of 'ControlObject::forceSet' D:\mixxx-main-pr-test\src\engine\sync\abletonlink.cpp(45): note: while trying to match the argument list '(unsigned __int64)'

ah, need captures in the IILE and the new lambda needs mutable so it can access the numLinkPeers mutably. I wonder why the original lambda didn't need mutable

Suggested change

m_pNumLinkPeers->setReadOnly();

m_pNumLinkPeers->forceSet(0);

// The callback is invoked on a Link - managed thread.

// The callback is the only entity, which access m_pNumLinkPeers

m_pLink->setNumPeersCallback([this](std::size_t numPeers) {

m_pNumLinkPeers->forceSet(numPeers);

});

// The callback is invoked on a Link - managed thread.

m_pLink->setNumPeersCallback([numLinkPeers = [&]{

ControlObject numLinkPeers(ConfigKey(group, numPeers));

numLinkPeers.setReadOnly();

numLinkPeers.forceSet(0);

return numLinkPeers;

}()](std::size_t numPeers) mutable {

numLinkPeers.forceSet(numPeers);

});

Doesn't work:

FAILED: CMakeFiles/mixxx-lib.dir/src/engine/sync/abletonlink.cpp.obj C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.341\bin\Hostx64\x64\cl.exe /nologo /TP -DAMD64 -DDJINTEROP_SOURCE -DLINK_PLATFORM_WINDOWS=1 -DMIXXX_BUILD_RELEASE -DMIXXX_DEBUG_ASSERTIONS_ENABLED -DMIXXX_DEBUG_ASSERTIONS_FATAL -DMIXXX_USE_QML -DMIXXX_USE_QOPENGL -DNOMINMAX -DPROTOBUF_USE_DLLS -DQT_CONCURRENT_LIB -DQT_CORE5COMPAT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_LABSQMLMODELS_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_QMLINTEGRATION_LIB -DQT_QMLMODELS_LIB -DQT_QMLWORKERSCRIPT_LIB -DQT_QML_LIB -DQT_QUICKCONTROLS2IMPL_LIB -DQT_QUICKCONTROLS2_LIB -DQT_QUICKLAYOUTS_LIB -DQT_QUICKSHAPES_LIB -DQT_QUICKTEMPLATES2_LIB -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_SHADERTOOLS_LIB -DQT_SQL_LIB -DQT_SVGWIDGETS_LIB -DQT_SVG_LIB -DQT_TABLET_SUPPORT -DQT_TESTCASE_BUILDDIR=\"D:/mixxx/build/x64__portable\" -DQT_TESTCASE_SOURCEDIR=\"D:/mixxx\" -DQT_TESTLIB_LIB -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -DSFC_SUPPORTS_SET_COMPRESSION_LEVEL -DUNICODE -DWIN32 -DWIN32_LEAN_AND_MEAN -DWIN64 -DWINVER=0x0601 -D_ATL_MIN_CRT -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING -D_UNICODE -D_USE_MATH_DEFINES -D_WIN32_WINNT=0x0601 -D_WIN64 -D__BATTERY__ -D__BROADCAST__ -D__BULK__ -D__ENGINEPRIME__ -D__FFMPEG__ -D__HID__ -D__HSS1394__ -D__LILV__ -D__MAD__ -D__MEDIAFOUNDATION__ -D__MODPLUG__ -D__OPUS__ -D__PORTMIDI__ -D__QTKEYCHAIN__ -D__RUBBERBAND__ -D__SNDFILE__ -D__SQLITE3__ -D__SSE2__ -D__SSE__ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STEM__ -D__VINYLCONTROL__ -D__WINDOWS__ -D__WV__ -ID:\mixxx\build\x64__portable\mixxx-lib_autogen\include -ID:\mixxx\src -ID:\mixxx\build\x64__portable\src -external:ID:\mixxx\lib\fidlib -external:ID:\mixxx\lib\portaudio -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include -external:ID:\mixxx\lib\rigtorp\SPSCQueue\include -external:ID:\mixxx\lib\replaygain -external:ID:\mixxx\lib\reverb -external:ID:\mixxx\lib\libshout-idjc\include -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\share\ableton-link\..\..\include\ableton -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\share\asio\..\..\include -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\djinterop -external:ID:\mixxx\lib\rekordbox-metadata -external:ID:\mixxx\lib\kaitai -external:ID:\mixxx\lib\mp3guessenc-0.27.4 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtConcurrent -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\share\Qt6\mkspecs\win32-msvc -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtGui -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtNetwork -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtOpenGL -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtPrintSupport -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtWidgets -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQml -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlIntegration -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtSql -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtSvg -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtTest -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtXml -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtShaderTools -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtSvgWidgets -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore5Compat -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuick -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlModels -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtLabsQmlModels -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlModels\6.5.3 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlModels\6.5.3\QtQmlModels -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore\6.5.3 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtCore\6.5.3\QtCore -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQml\6.5.3 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQml\6.5.3\QtQml -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickControls2 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickControls2Impl -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickLayouts -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtGui\6.5.3 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtGui\6.5.3\QtGui -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuick\6.5.3 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuick\6.5.3\QtQuick -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickShapes -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickShapes\6.5.3 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickShapes\6.5.3\QtQuickShapes -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickTemplates2 -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQuickWidgets -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\Qt6\QtQmlWorkerScript -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\taglib -external:ID:\mixxx\lib\qm-dsp -external:ID:\mixxx\lib\qm-dsp\include -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\opus -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\hidapi -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\libusb-1.0 -external:ID:\mixxx\lib\xwax -external:ID:\mixxx\buildenv\mixxx-deps-2.5-x64-windows-06fe9b5\installed\x64-windows\include\wavpack -external:W0 /DWIN32 /D_WINDOWS /EHsc /Zc:__cplusplus /Zc:inline /Z7 /O2 /DNDEBUG -std:c++20 -MD /UTF8 /fp:fast /Gy /W3 /wd4200 -DPA_USE_JACK=1 -DPA_USE_ASIO=1 -DPA_USE_DS=1 -DPA_USE_WMME=1 -DPA_USE_WASAPI=1 -DPA_USE_WDMKS=1 -Zc:__cplusplus -permissive- -utf-8 /YuD:/mixxx/build/x64__portable/CMakeFiles/mixxx-lib.dir/cmake_pch.hxx /FpD:/mixxx/build/x64__portable/CMakeFiles/mixxx-lib.dir/./cmake_pch.cxx.pch /FID:/mixxx/build/x64__portable/CMakeFiles/mixxx-lib.dir/cmake_pch.hxx /showIncludes /FoCMakeFiles\mixxx-lib.dir\src\engine\sync\abletonlink.cpp.obj /Fdmixxx-lib.dir\mixxx-lib.pdb /FS -c D:\mixxx\src\engine\sync\abletonlink.cpp D:\mixxx\src\engine\sync\abletonlink.cpp(27): error C2614: 'AbletonLink': illegal member initialization: 'm_pNumLinkPeers' is not a base or member D:\mixxx\src\engine\sync\abletonlink.cpp(47): error C2280: 'ControlObject::ControlObject(ControlObject &&)': attempting to reference a deleted function D:\mixxx\src\control/controlobject.h(189): note: see declaration of 'ControlObject::ControlObject'

I suggest you compile it yourself first, because this two person trial and error development seems not very efficient to me.

Okay, I've investigated and my conclusion is that moving this into the lambda is infeasible because link requires the lambda to be copy-able. This would require making the member of the lambda a std::shared_ptr<ControlObject> which has unnecessary overhead. They also don't allow mutable which is another oversight in the link API. (not that that is required because TIL that you can still call mutable member functions of a pointer managed by a const unique_ptr, which seems dangerous).

The only recommendation I would make then is moving the m_pNumLinkPeers above m_pLink in the class definition so it doesn't get destroyed while m_pLink still references it.

src/engine/sync/abletonlink.cpp

Swiftb0y · 2024-09-06T18:25:20Z

src/engine/sync/abletonlink.cpp

+    m_audioBufferTimeMicros = std::chrono::microseconds(
+            bufferSize / mixxx::audio::ChannelCount::stereo() /
+            sampleRate * 1000000);


this seems unused.

Swiftb0y · 2024-09-06T18:28:55Z

src/engine/sync/abletonlink.h

+    std::chrono::microseconds m_audioBufferTimeMicros;
+    std::chrono::microseconds m_absTimeWhenPrevOutputBufferReachesDac;
+    std::chrono::microseconds m_sampleTimeAtStartCallback;
+    std::chrono::microseconds m_timeAtStartCallback;


can be simplified

m_audioBufferTimeMicros is only set, never read

m_sampleTimeAtStartCallback is only initialized, never changed nor read

m_timeAtStartCallback is only set, never read

Suggested change

std::chrono::microseconds m_audioBufferTimeMicros;

std::chrono::microseconds m_absTimeWhenPrevOutputBufferReachesDac;

std::chrono::microseconds m_sampleTimeAtStartCallback;

std::chrono::microseconds m_timeAtStartCallback;

std::chrono::microseconds m_absTimeWhenPrevOutputBufferReachesDac;

src/engine/sync/abletonlink.h

src/engine/sync/abletonlink.cpp

…iously included to address a compilation issue with AbletonLink in C++20 mode, but it is no longer needed, due to an upstream fix in 3.0.6, which is now part of our VCPKG buildenv.

spensbot and others added 30 commits April 11, 2021 23:08

Ableton Link initial integration

5412312

On startup, Mixxx will enable link and join the active link session We have much to do for Mixxx to become a link-compatible app Basically, Mixxx needs to respond to & update the active link session to synchronize bpm & phase

Apply pre-commit.patch from github check

36c3084

Copy ableton-link directly

5faedad

Remove the ableton link submodule

Merge remote-tracking branch 'upstream/main' into abeltonlink

bc30491

Added ableton-link-dev to debian buildenv

250ff3e

Find installed Ableton Link

a5d9ba3

Fixed AbletonLink embedding

7bd8463

Fixed typo: Call onCallbackEnd instead of onCallbackStart

a80b6a6

Removed unnecessary include statements

12bbb2b

Change logging to standard Qt commands Use Doxygen style comments in abletonlink.h

Pre-Commit

f5cbbaf

Use m_audioBufferMicros to determine the latency between CPU clock an…

094f0cf

…d the speaker output

Merge remote-tracking branch 'upstream/Main' into abletonlink

96e2fc2

Made AbletonLink compile in C++20 environment

2305770

Added GUI controls for AbletonLink (Latenight Palemoon only)

9fb58bc

Pre-Commit

11b2278

Removed conflicting delay calculation code

29c2eeb

Replaced full AbletonLink 3.03 copy in lib folder by stripped down ve…

8350ac5

…rsion of 3.05 Disabled system AbletonLink for Debian, because this package is broken in Ubuntu 20.04

Build fixes

550eaac

Added ASIO to debian_buildenv.sh

48630d3

Added ASIO to debian_buildenv.sh

abb3184

Pre-Commit

5b92646

Added local ASIO

97b6a15

Fix clang link failure - missing latomic

65b1c7d

Added ASIO CMake and copyright file

7094a7f

atomics check

acec4c1

_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING

d867974

Set numPeers CO in callback

b7e3373

Moved debug code from header to cpp

Don't call callbacks if m_pAbletonLink is the initiator of the sync c…

7232525

…hange

Added CheckAtomic.cmake from KDE Krita project

f616307

Pre-Commit

89ac353

JoergAtGithub removed code quality packaging controller backend labels Aug 18, 2024

JoergAtGithub force-pushed the abletonlink branch from ddff131 to f498e28 Compare August 18, 2024 11:43

github-actions bot added code quality packaging controller backend labels Aug 18, 2024

fwcd reviewed Aug 18, 2024

View reviewed changes

src/engine/sync/abletonlink.h Outdated Show resolved Hide resolved

src/engine/sync/abletonlink.h Show resolved Hide resolved

JoergAtGithub force-pushed the abletonlink branch 5 times, most recently from 262642c to 30b8374 Compare August 18, 2024 13:55

Use ableton::platforms::stl::Clock (which is std::chrono::steady_cloc…

96c5007

…k) as clock reference

JoergAtGithub force-pushed the abletonlink branch from 30b8374 to 96c5007 Compare August 18, 2024 14:05

JoergAtGithub added 6 commits August 18, 2024 17:07

Refactor EngineSync::notifyScratching for readability

5aa7ac7

Fix broken code formatting

d4f592b

Refactor for readability and consistency

f9d46d7

Refactored various methods in `AbletonLink` to use `auto` and `const auto` for improved readability and simplicity. Updated floating-point literals to use `1.0` instead of `1.` for clarity and consistency.

Improved readability and comments

5c601b9

Merge remote-tracking branch 'upstream/main' into abletonlink2

7195dea

Revert wrong pre-commit fix

4f3d3d9

JoergAtGithub removed the packaging label Aug 18, 2024

Swiftb0y reviewed Sep 6, 2024

View reviewed changes

JoergAtGithub added 6 commits September 6, 2024 21:40

Remove MSVC flag_HAS_DEPRECATED_RESULT_OF. This definition was prev…

7502dcb

…iously included to address a compilation issue with AbletonLink in C++20 mode, but it is no longer needed, due to an upstream fix in 3.0.6, which is now part of our VCPKG buildenv.

Remove Q_UNUSED macros by omitting unused parameter names

c028793

Make m_group in AbletonLink mutable

1f4f192

Switch debug output from qDebug() to kLogger.debug()

faf9991

Merge remote-tracking branch 'upstream/main' into abletonlink2

e181503

Merge remote-tracking branch 'upstream/main' into abletonlink2

f142616

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full Ableton Link support #10999

Full Ableton Link support #10999

JoergAtGithub commented Oct 24, 2022 •

edited

Loading

jonahclarsen commented Sep 5, 2024

Swiftb0y Sep 6, 2024

JoergAtGithub Sep 7, 2024

Swiftb0y Sep 7, 2024

JoergAtGithub Sep 7, 2024

Swiftb0y Sep 8, 2024

Swiftb0y Sep 8, 2024

JoergAtGithub Sep 8, 2024 •

edited

Loading

Swiftb0y Sep 9, 2024 •

edited

Loading

JoergAtGithub Sep 9, 2024

Swiftb0y Sep 10, 2024 •

edited

Loading

Swiftb0y Sep 6, 2024

Swiftb0y Sep 6, 2024

Full Ableton Link support #10999

Are you sure you want to change the base?

Full Ableton Link support #10999

Conversation

JoergAtGithub commented Oct 24, 2022 • edited Loading

jonahclarsen commented Sep 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoergAtGithub Sep 8, 2024 • edited Loading

Choose a reason for hiding this comment

Swiftb0y Sep 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Swiftb0y Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoergAtGithub commented Oct 24, 2022 •

edited

Loading

JoergAtGithub Sep 8, 2024 •

edited

Loading

Swiftb0y Sep 9, 2024 •

edited

Loading

Swiftb0y Sep 10, 2024 •

edited

Loading