fix: prevent double free on DigitsRenderer

mixxxdj · Nov 10, 2024 · e4ea6c5 · e4ea6c5
1 parent 694542d
commit e4ea6c5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/waveform/renderers/allshader/digitsrenderer.cpp b/src/waveform/renderers/allshader/digitsrenderer.cpp
@@ -169,12 +169,12 @@ void allshader::DigitsRenderer::updateTexture(
         blur->setBlurRadius(static_cast<qreal>(m_penWidth) / 3);
 
         QGraphicsScene scene;
-        QGraphicsPixmapItem item;
-        item.setPixmap(QPixmap::fromImage(image));
-        item.setGraphicsEffect(blur.release());
+        auto item = std::make_unique<QGraphicsPixmapItem>();
+        item->setPixmap(QPixmap::fromImage(image));
+        item->setGraphicsEffect(blur.release());
         image.fill(Qt::transparent);
         QPainter painter(&image);
-        scene.addItem(&item);
+        scene.addItem(item.release());
         scene.render(&painter, QRectF(), QRectF(0, 0, image.width(), image.height()));
     }