This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
fix(http_client): Occasional response corruption #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a non null terminated buffer being used in string stream
benank
changed the title
benank
changed the title
benank
changed the title
benank
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a non null terminated buffer being used in string stream. It corrupts the response and then can't be parsed into a valid json object.
Difficult to reproduce. I was only able to reproduce it in one specific project with one specific mixer user (testing other users and other projects worked fine). Not entirely sure why it happens so rarely, but it was reproducible on my end and this fixes it.