Accept TGA files without the optional footer. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit worried that the test on the second byte might be a bit too relaxed to identify a file as TGAv1. Is there some other information in the header that could be used to be more certain? |
|
There are the Color map specification (field 4), and Image specification (field 5). But some of these tests are being done in |
|
Right -- but my message before was with regards to avoiding the false positive, which could be problematic. |
aviadlevis
pushed a commit
to aviadlevis/mitsuba
that referenced
this pull request
May 29, 2017
… starting experiment mitsuba-renderer#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mitsuba to read TGA files without the optional footer.