Rename Mutex and Cond methods for consistency #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the names acquire/release and acquire_spec/release_spec came from HeapLang, and mutexes were the only place this convention was used. For consistency with how we typically name functions and specs (and to match Go), this commit renames to `Mutex__Lock` and `wp_Mutex__Lock`, and similarly for Unlock. At the same time we make the Cond methods more consistent with this convention, although its specs already used the `wp_` naming style.
|
I've already made the changes to goose locally and will push that and update the goose output once this merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the names acquire/release and acquire_spec/release_spec came from HeapLang, and mutexes were the only place this convention was used.
For consistency with how we typically name functions and specs (and to match Go), this commit renames to
Mutex__Lockandwp_Mutex__Lock, and similarly for Unlock. At the same time we make the Cond methods more consistent with this convention, although its specs already used thewp_naming style.