Make Var a coercion #110
Merged
Make Var a coercion #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchajed
force-pushed
the
tchajed/remove-var-coercion
branch
from
f6d3b06
to
abaaea3
Compare
It was originally not due to failing the "uniform inheritance criteria", but this criteria is no longer required. This should ensure that variables are actually printed as strings, hiding the Var coercion, which will make code much more readable without the ugly hack of the `Var'` coercions. The massive fallout is due to removing many coercions Var' that were defined for specific type parameters, all of which can now use the single coercion on Var.
tchajed
force-pushed
the
tchajed/remove-var-coercion
branch
from
abaaea3
to
03205f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally not due to failing the "uniform inheritance criteria", but this criteria is no longer required.
This should ensure that variables are actually printed as strings, hiding the Var coercion, which will make code much more readable without the ugly hack of the
Var'coercions.The massive fallout is due to removing many coercions Var' that were defined for specific type parameters, all of which can now use the single coercion on Var.