Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aravp-mobile
Copy link

UI Improvements of the application

  • Info about Issue or bug

Fixes: #10

Describe the changes you've made

I have changed the bottom navigation view with some chip navigation bar into it.

@mishraaditya595
Copy link
Owner

Can you please attach the apk file here?

@aravp-mobile
Copy link
Author

https://drive.google.com/file/d/1HnobYn6zcC2jElTljOxYHw4lH6I4TgVZ/view?usp=sharing

@mishraaditya595 apk not supporting. So I have updated in drive. Kindly check the link

@mishraaditya595
Copy link
Owner

Well, the navigation bar does look pretty good but does not fit into when dark mode is enabled. Plus the icons does not convey what the fragment is about. Try fixing these.

@aravp-mobile
Copy link
Author

@mishraaditya595 I have changed the svg file for all 4 parts. Please check and let me know about the UI. I am still working on dark mode. Please merge this PR as in priority as dark mode is new to me. So I am working on it.

@mishraaditya595
Copy link
Owner

provide the apk for the same

@aravp-mobile
Copy link
Author

@mishraaditya595
Copy link
Owner

hey @av-arvind77, there are several merge conflicts. Can you update this branch with the latest commits. The last commits were your PR #61

@aravp-mobile
Copy link
Author

Yes sure @mishraaditya595

@aravp-mobile
Copy link
Author

@mishraaditya595 I am unable to resolve conflicts. Can you please guide me to resolve this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to the entire UI
3 participants