Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anjali1361 patch 1 #45

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

anjali1361
Copy link

Related Issuse or bug

  • set the icon for document at bottom navigation
  • set the title for MainActivity.java via activity_main.xml
  • set the size of title same as that of portrait mode in landscape mode for MainActivity and SettingsActivity.

Fixes: #[issue number that will be closed through this PR]

Describe the changes you've made

1.set the icon for document at bottom navigation
2.set the title for MainActivity.java via activity_main.xml
3.set the size of title same as that of portrait mode in landscape mode for MainActivity and SettingsActivity.

Fill in the form: https://forms.gle/uTfMxj8282nzwPck8

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Verified on my device using USB debugging.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

Added icon for document in drawable for bottom navigation view and modified the code in bottom_nav_menu.xml inside menu folder.
added title for MainAtivity.java via activity_main.xml
Edited to set the size of title at Actionbar in landscape mode as that in portrait mode.
@mishraaditya595
Copy link
Owner

Hey @anjali1361, is this a part of the GSSOC21?

@anjali1361
Copy link
Author

anjali1361 commented Mar 14, 2021 via email

@mishraaditya595
Copy link
Owner

Can you attach the apk file here?

@anjali1361
Copy link
Author

anjali1361 commented Mar 17, 2021 via email

@mishraaditya595
Copy link
Owner

mishraaditya595 commented Mar 19, 2021

Please allow access @anjali1361

@anjali1361
Copy link
Author

anjali1361 commented Mar 19, 2021 via email

@mishraaditya595
Copy link
Owner

Hey, the listview/ recycler view is not working and the document scanning is not working even. Can you enumerate what all you have done with the PR?

@anjali1361
Copy link
Author

anjali1361 commented Mar 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants