-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anjali1361 patch 1 #45
Open
anjali1361
wants to merge
6
commits into
mishraaditya595:master
Choose a base branch
from
anjali1361:anjali1361-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added icon for document in drawable for bottom navigation view and modified the code in bottom_nav_menu.xml inside menu folder.
added title for MainAtivity.java via activity_main.xml
…t in portrait mode.
Edited to set the size of title at Actionbar in landscape mode as that in portrait mode.
Hey @anjali1361, is this a part of the GSSOC21? |
Yes, This is the part of GSSoC
…On Sun, 14 Mar, 2021, 6:54 PM Aditya Mishra, ***@***.***> wrote:
Hey @anjali1361 <https://github.com/anjali1361>, is this a part of the
GSSOC21?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOUJQKHFLDBH4VMOQI5M6VTTDS2JNANCNFSM4ZAMOUQQ>
.
|
Can you attach the apk file here? |
app-debug.apk
<https://drive.google.com/file/d/1EoIriQ7zGky3Am8BUD1FFCQS5R_yzGV6/view?usp=drive_web>
…On Wed, 17 Mar 2021 at 10:21, Aditya Mishra ***@***.***> wrote:
Can you attach the apk file here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOUJQKHXSXEZBT27RBYFQKDTEAYLXANCNFSM4ZAMOUQQ>
.
|
Please allow access @anjali1361 |
done
…On Fri, 19 Mar, 2021, 10:07 AM Aditya Mishra, ***@***.***> wrote:
Please allow access
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOUJQKGKW5MYUVVLL426I53TELIKLANCNFSM4ZAMOUQQ>
.
|
Hey, the listview/ recycler view is not working and the document scanning is not working even. Can you enumerate what all you have done with the PR? |
A total of three changes that I have made listed below:-
previous - The icon for home and document was same in bottom navigation bar
my-code - Changed the icon for document to include new one
previous - The title size in landscape mode seems smaller then in portrait
mode
my-code - resolved this to same title size for all activities in landscape
as well as portrait mode
previous - no title appears for MainActivity(the activity where bottom
navigation is implemented)
my-code - added the title in MainActivity via it's corresponding xml file
…On Fri, 19 Mar, 2021, 11:19 AM Aditya Mishra, ***@***.***> wrote:
Hey, the listview/ recycler view is not working and the document scanning
is not working even. Can you enumerate what all you have done with the PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOUJQKFSOMCNE5GINKIVTF3TELQWNANCNFSM4ZAMOUQQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issuse or bug
Fixes: #[issue number that will be closed through this PR]
Describe the changes you've made
1.set the icon for document at bottom navigation
2.set the title for MainActivity.java via activity_main.xml
3.set the size of title same as that of portrait mode in landscape mode for MainActivity and SettingsActivity.
Fill in the form: https://forms.gle/uTfMxj8282nzwPck8
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Verified on my device using USB debugging.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NA
Checklist:
Screenshots