Jet Core

------------ * ORM DataModel: Bug fix (fatal error): DateTime->onOnlyDate was ignored. This made it impossible to create queries with only date and not time.
mirekmarek · Jul 5, 2024 · 1c094f1 · 1c094f1
1 parent 9a7c275
commit 1c094f1
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/library/Jet/DataModel/Backend/MSSQL.php b/library/Jet/DataModel/Backend/MSSQL.php
@@ -390,7 +390,10 @@ protected function _getValue( mixed $value ): float|int|string
 		}
 
 		if( $value instanceof Data_DateTime ) {
-			$value = $value->format( 'Y-m-d H:i:s' );
+			$value = $value->isOnlyDate() ?
+				$value->format( 'Y-m-d' )
+				:
+				$value->format( 'Y-m-d H:i:s' );
 		}
 
 		if(

diff --git a/library/Jet/DataModel/Backend/MySQL.php b/library/Jet/DataModel/Backend/MySQL.php
@@ -389,7 +389,10 @@ protected function _getValue( mixed $value ): float|int|string
 		}
 
 		if( $value instanceof Data_DateTime ) {
-			$value = $value->format( 'Y-m-d H:i:s' );
+			$value = $value->isOnlyDate() ?
+				$value->format( 'Y-m-d' )
+				:
+				$value->format( 'Y-m-d H:i:s' );
 		}
 
 		if(

diff --git a/library/Jet/DataModel/Backend/PgSQL.php b/library/Jet/DataModel/Backend/PgSQL.php
@@ -388,7 +388,10 @@ protected function _getValue( mixed $value ): float|int|string
 		}
 
 		if( $value instanceof Data_DateTime ) {
-			$value = $value->format( 'Y-m-d H:i:s' );
+			$value = $value->isOnlyDate() ?
+				$value->format( 'Y-m-d' )
+				:
+				$value->format( 'Y-m-d H:i:s' );
 		}
 
 		if(
@@ -548,7 +551,6 @@ protected function _getRecord( DataModel_RecordData $record, bool $quote = true,
 	 */
 	public function transactionStart(): void
 	{
-		//TODO:
 		/*
 		$this->getDbWrite()->beginTransaction();
 		*/
@@ -560,7 +562,6 @@ public function transactionStart(): void
 	 */
 	public function transactionRollback(): void
 	{
-		//TODO:
 		/*
 		if( $this->getDbWrite()->inTransaction() ) {
 			$this->getDbWrite()->rollBack();
@@ -573,7 +574,6 @@ public function transactionRollback(): void
 	 */
 	public function transactionCommit(): void
 	{
-		//TODO:
 		/*
 		if( $this->getDbWrite()->inTransaction() ) {
 			$this->getDbWrite()->commit();

diff --git a/library/Jet/DataModel/Backend/SQLite.php b/library/Jet/DataModel/Backend/SQLite.php
@@ -490,7 +490,10 @@ protected function _getValue( mixed $value ): float|int|string
 		}
 
 		if( $value instanceof Data_DateTime ) {
-			$value = $value->format( 'Y-m-d H:i:s' );
+			$value = $value->isOnlyDate() ?
+				$value->format( 'Y-m-d' )
+				:
+				$value->format( 'Y-m-d H:i:s' );
 		}
 
 		if( is_array( $value ) ) {