Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versions from .tool-versions for CI #219

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Use versions from .tool-versions for CI #219

merged 3 commits into from
Dec 6, 2022

Conversation

JoeyBG
Copy link
Contributor

@JoeyBG JoeyBG commented Dec 6, 2022

📖 Description

Instead of manually having to update the CI workflow file, we can leverage recently merged functionality (actions/setup-node#373 & erlef/setup-beam#159) to automatize this.

🦀 Dispatch

  • #dispatch/devops

@JoeyBG JoeyBG marked this pull request as ready for review December 6, 2022 17:11
@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

  • @bducharme (contributor with 1 commits in the last 90 days and 3 commits overall)
  • @Boubalou (reviewer for the devops stack)

Copy link
Member

@simonprev simonprev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@JoeyBG JoeyBG merged commit 852a351 into main Dec 6, 2022
@JoeyBG JoeyBG deleted the improve-ci-setup branch December 6, 2022 17:37
Copy link
Member

@Boubalou Boubalou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@remi
Copy link
Member

remi commented Dec 6, 2022

Une belle idée de post "TIL" sur https://craft.mirego.com ça! 😁

Copy link
Contributor

@gcauchon gcauchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants