A-1206908284153320: switch to api v2 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyxem
commented
Mar 30, 2024
| @@ -106,6 +109,19 @@ const SendTransaction = ({ | |||
| setPassValidity(false) | |||
| setPass('') | |||
| setAllowClosing(true) | |||
| } else if (e.message.includes('minimum fee')) { | |||
There was a problem hiding this comment.
For the cases when fee was not calculates properly, then provided by server.
anyxem
commented
Mar 30, 2024
| @@ -56,19 +59,40 @@ const getTxInput = async (outpointSourceId) => { | |||
| ) | |||
| } | |||
|
|
|||
| const getTransactionUtxos = (utxos, amountToUse, fee = 0) => { | |||
| let balance = 0 | |||
| /** | |||
There was a problem hiding this comment.
Added comment with small explanation how was fixed fee error
|
Reverted error 870b8f7 because Tx error may be overwritten with empty string. Different errors handling could be done in scope of refactoring |
added datetime lookup
|
fixed delegation_id display
|
owlsua
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Description
Switched to API v2
Bug fix of the cases when server return
Mempool error: Transaction does not pay sufficient fees to be relayedBugfix for Signature errors by using more precise BigInt across functions related to collecting data to server. UI using floats or casting to Numbers
More
📋 Checklist:
A-[id of Asana task]A-[id of Asana task]: [short description]prettierchecklintcheck