Refactor/wallet generic signer #1783

OBorce · 2024-06-18T08:58:20Z

add a generic signer provider for creating a software or a hardware signer
make account key chain generic to allow using it with and without a VRF keychain
add an implementation for the trezor signer
copy auto generated trezor client to communicate with a connected trezor device
add new hardware-wallet option when creating and opening a wallet in the CLI and RPC wallet commands

do_checks.sh

wallet/wallet-controller/src/lib.rs

wallet/src/signer/trezor_signer/mod.rs

build-tools/codecheck/codecheck.py

crypto/src/key/secp256k1/extended_keys.rs

crypto/src/key/extended.rs

node-gui/src/backend/backend_impl.rs

azarovh · 2024-08-06T13:33:43Z

Cargo.toml

@@ -287,3 +287,6 @@ opt-level = 2
 [profile.dist]
 inherits = "release"
 lto = "off"
+
+[features]
+trezor = []


I think it should be enabled in CI

wallet/src/signer/trezor_signer/mod.rs

wallet/Cargo.toml

wallet/wallet-cli-commands/src/helper_types.rs

wallet/wallet-cli-commands/src/command_handler/mod.rs

ImplOfAnImpl · 2024-08-07T16:54:43Z

wallet/wallet-controller/src/lib.rs

+        match &self.wallet {
+            WalletType2::Software(w) => w.seed_phrase(),
+            #[cfg(feature = "trezor")]
+            WalletType2::Trezor(w) => w.seed_phrase(),
+        }


These match statements pollute the code; also, some of them are duplicated.
Perhaps it's better to encapsulate all of them inside impl WalletType2?

P.S. Personally, I'd probably try to use https://github.com/kobzol/rust-delegate for this. Not insisting on this, of course.

moved inside the impl

wallet/wallet-controller/src/lib.rs

wallet/src/signer/trezor_signer/mod.rs

azarovh · 2024-08-24T09:56:26Z

wallet/src/signer/trezor_signer/mod.rs

+                        SignatureStatus::FullySigned,
+                        SignatureStatus::FullySigned,
+                    )),
+                    InputWitness::Standard(sig) => match destination {


we need a TODO and a github issue (so we won't forget) to support HTLC signing after my pr is merged

wallet/src/signer/trezor_signer/mod.rs

azarovh · 2024-08-24T10:40:07Z

wallet/src/signer/trezor_signer/tests.rs

+    let db = Arc::new(Store::new(DefaultBackend::new_in_memory()).unwrap());
+    let mut db_tx = db.transaction_rw_unlocked(None).unwrap();
+
+    let master_key_chain = MasterKeyChain::new_from_mnemonic(


why mnemonic?

I don't fully understand how it's tested, this is run manually right? It looks like possible to run emulator with cli and automate this. Let's maybe discuss it because I'm afraid such functionality is not tested enough

The current test assumes the device will be initialized with the same mnemonic, but that can be fixed later as the tests can't run automatically now anyway.

To automate the tests I think we will need first to make the signing async, so that we can return from the wallet the status of the signing, i.e. when it is waiting for a button to be pressed on the trezor device

wallet/src/signer/trezor_signer/mod.rs

azarovh · 2024-08-24T10:53:15Z

wallet/wallet-cli-commands/src/lib.rs

+
+        /// Create a wallet using a connected hardware wallet. Only the public keys will be kept in
+        /// the software wallet
+        #[arg(long, conflicts_with_all(["mnemonic", "passphrase"]))]


it also conflicts with whether_to_store_seed_phrase

whether_to_store_seed_phrase was a required parameter I am not sure if we should break backwards compatibility or not, that is why I left it alone, and just check that it is set to false.

wallet/wallet-cli-commands/src/lib.rs

wallet/wallet-controller/src/types/mod.rs

azarovh · 2024-08-24T11:15:12Z

wallet/wallet-cli-commands/src/lib.rs

+        whether_to_store_seed_phrase: CliStoreSeedPhrase,
+
+        /// Mnemonic phrase (12, 15, or 24 words as a single quoted argument). If not specified, a new mnemonic phrase is generated and printed.
+        mnemonic: Option<String>,


should it be just String? btw we can remove mnemonic from CreateWallet

it is optional because of the hardware wallet option.

wallet/src/signer/trezor_signer/mod.rs

- it will rescan the blokchain on wallet creation - wallet-create will only scan forward from the current block height

OBorce force-pushed the refactor/wallet-generic-signer branch from e1f4596 to 37b71b9 Compare June 20, 2024 04:25

OBorce force-pushed the refactor/wallet-generic-signer branch 6 times, most recently from 626b7d1 to fb2af0d Compare August 1, 2024 07:47

OBorce marked this pull request as ready for review August 1, 2024 12:04

OBorce requested review from erubboli, azarovh and ImplOfAnImpl as code owners August 1, 2024 12:04

OBorce commented Aug 1, 2024

View reviewed changes

do_checks.sh Outdated Show resolved Hide resolved

OBorce commented Aug 1, 2024

View reviewed changes

wallet/wallet-controller/src/lib.rs Outdated Show resolved Hide resolved

azarovh reviewed Aug 5, 2024

View reviewed changes

wallet/src/signer/trezor_signer/mod.rs Outdated Show resolved Hide resolved

OBorce force-pushed the refactor/wallet-generic-signer branch from 726bb45 to 855cfce Compare August 6, 2024 10:54

azarovh reviewed Aug 6, 2024

View reviewed changes

ImplOfAnImpl approved these changes Aug 7, 2024

View reviewed changes

OBorce force-pushed the refactor/wallet-generic-signer branch 2 times, most recently from 1cd8110 to c23f38d Compare August 13, 2024 23:23

azarovh reviewed Aug 24, 2024

View reviewed changes

OBorce force-pushed the refactor/wallet-generic-signer branch from c23f38d to 4824da8 Compare August 30, 2024 16:09

OBorce force-pushed the refactor/wallet-generic-signer branch 2 times, most recently from f787225 to a35f2c3 Compare September 11, 2024 08:35

OBorce added 7 commits September 12, 2024 00:29

Add SignerProvider generic to the wallet

2e4bd4b

Add optional trezor signer support

f4baaf0

add trezor-client generated code

cf3f5e3

refactor signer provider for creating wallet accounts

b718692

Add trezor hardware wallet Account implementation

6b55f3e

add cli command arguments for creating trezor wallet

1a70909

add support for all inputs and outputs to trezor signer

e415bf5

OBorce added 23 commits September 12, 2024 00:31

fix pipeline errors

8127225

fix trezor feature compilation

b6d55b0

update rpc docs

52db397

remove the trezor client code and reference the git repository

92eb818

add support for Hot wallet with trezor device

8ceee6f

add wallet-recover command

3fb5a55

- it will rescan the blokchain on wallet creation - wallet-create will only scan forward from the current block height

add additional UTXO info to partially signed tx

697a2e0

update RPC docs

1ea9e5a

add additional token info for utxos in partially signed tx

47e6497

clean up from review comments

8d63c93

update rpc docs

f1ad42b

Add additional utxo info for tx outputs

deff18c

move PartiallySignedTx to wallet

2717f76

refactor review comments

b922f55

refactor wallet utxo token_id uses

6ce311f

add separate additional data for anyonecanstake

84d19d1

add support for signing HTLC outputs with trezor

51dfc21

fix comments

34b751f

extract runtime wallet functionality

b40d3ba

fix functional tests

785ae3a

fix trezor test

e21fcd5

add ChangeTokenMetadataUri to trezor singer

4b6c248

Convert TrezorError to string

2014928

OBorce force-pushed the refactor/wallet-generic-signer branch from 2157893 to 2014928 Compare September 11, 2024 22:40

OBorce added 2 commits September 17, 2024 20:50

Add support for orders in trezor

1f977ff

fix trezor produce from stake additional info

037f258

OBorce force-pushed the refactor/wallet-generic-signer branch from 6c3d058 to 037f258 Compare September 17, 2024 19:42

OBorce requested review from azarovh and ImplOfAnImpl September 18, 2024 08:53

add all inputs/outputs to trezor test

826f2ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/wallet generic signer #1783

Refactor/wallet generic signer #1783

OBorce commented Jun 18, 2024 •

edited

Loading

azarovh Aug 6, 2024

ImplOfAnImpl Aug 7, 2024

OBorce Sep 17, 2024

azarovh Aug 24, 2024

azarovh Aug 24, 2024

OBorce Sep 17, 2024

azarovh Aug 24, 2024

OBorce Sep 17, 2024

azarovh Aug 24, 2024

OBorce Sep 17, 2024

Refactor/wallet generic signer #1783

Are you sure you want to change the base?

Refactor/wallet generic signer #1783

Conversation

OBorce commented Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OBorce commented Jun 18, 2024 •

edited

Loading