Mark the SeleniumDriver as deprecated in favor of Selenium2 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| The SeleniumRC protocol used by this driver is deprecated and does not | ||
| support all Mink features. For this reason, the SeleniumDriver is deprecated | ||
| in favor of the :doc:`/drivers/selenium2`, which is based on the new |
There was a problem hiding this comment.
I'm not sure if leading / in link to other document is needed.
There was a problem hiding this comment.
Well, we have 2 choices: either absolute references (which need the leading slash) or relative references (which would be :doc:selenium2``). I'm using absolute references everywhere currently (easier when moving a file to a different location as all references inside it don't need to be changed, and searching for references to a given file is also easier)
|
Maybe we should also update |
|
@aik099 an update of all driver readmes is planned to link to the online doc (see minkphp/Mink#635). This will be part of it. |
stof
added a commit
that referenced
this pull request
Feb 21, 2015
Mark the SeleniumDriver as deprecated in favor of Selenium2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.