Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: into_jwk takes Option<impl Into<..>> #98

Merged
merged 1 commit into from
Apr 14, 2024
Merged

fix: into_jwk takes Option<impl Into<..>> #98

merged 1 commit into from
Apr 14, 2024

Conversation

Stupremee
Copy link
Contributor

No description provided.

@Stupremee Stupremee linked an issue Apr 13, 2024 that may be closed by this pull request
IntoJsonWebKey::into_jwk should take Option<impl Into<JsonWebAlgorithm>> instead of impl Into<Option<JsonWebAlgorithm>> #46
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.2%. Comparing base (dad2321) to head (b5db0e8).

Additional details and impacted files
Files Coverage Δ
src/jwk.rs 44.8% <ø> (ø)
src/jwk/symmetric/hmac.rs 37.8% <0.0%> (ø)
src/jwk/okp/curve25519/ed25519.rs 55.3% <0.0%> (+1.4%) ⬆️
src/macros.rs 67.3% <0.0%> (ø)
src/jwk/rsa.rs 74.6% <0.0%> (ø)

@Stupremee Stupremee added this pull request to the merge queue Apr 14, 2024
Merged via the queue into main with commit 7e5b1b5 Apr 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erik1000 Erik1000 Erik1000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Stupremee @Erik1000