Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Mac::verify_reset for Hmac verifying #88

Merged
merged 2 commits into from
Nov 4, 2023
Merged

fix: use Mac::verify_reset for Hmac verifying #88

merged 2 commits into from
Nov 4, 2023

Conversation

Stupremee
Copy link
Contributor

No description provided.

@Stupremee Stupremee linked an issue Nov 4, 2023 that may be closed by this pull request
Update Hmac implementation to use digest::Mac::verify_reset #86
Closed
@Stupremee Stupremee marked this pull request as ready for review November 4, 2023 14:19
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #88 (fe5e645) into main (ab0d001) will decrease coverage by 0.2%.
The diff coverage is 80.0%.

Files Coverage Δ
src/jwk/symmetric/hmac.rs 35.2% <80.0%> (-4.9%) ⬇️

@Stupremee Stupremee added this pull request to the merge queue Nov 4, 2023
@Stupremee Stupremee removed this pull request from the merge queue due to a manual request Nov 4, 2023
@Stupremee Stupremee changed the title 86 update hmac implementation to use digestmacverify reset fix: use Mac::verify_reset for Hmac verifying Nov 4, 2023
@Stupremee Stupremee added this pull request to the merge queue Nov 4, 2023
Merged via the queue into main with commit f74c58e Nov 4, 2023
18 checks passed
@Erik1000 Erik1000 deleted the 86-update-hmac-implementation-to-use-digestmacverify_reset branch November 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erik1000 Erik1000 Erik1000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Hmac implementation to use digest::Mac::verify_reset
2 participants
@Stupremee @Erik1000