Fix a bug in (un)marshaling ReplicationConfig #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
previously approved these changes
Aug 30, 2023
HoKim98
changed the title
balamurugana
requested changes
Sep 1, 2023
HoKim98
force-pushed
the
fix-a-bug-in-marshaling-replication-config
branch
from
cba4568
to
ff04f3b
Compare
balamurugana
requested changes
Sep 2, 2023
| data.push_str("<Status>"); | ||
| data.push_str(&v); | ||
| data.push_str("</Status>"); | ||
| data.push_str("<Role>"); |
There was a problem hiding this comment.
Firstly open an issue with complete information about current encode/decode issue of ReplicationConfig. I do not understand what you are trying to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.