add support for sso auth #1911
Open
add support for sso auth #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@harshavardhana is it an explicit goal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds credential support for retrieving AWS SSO credentials and using those against a bucket store. I also added a test.
SSO is becoming increasingly common for many benefits. I figured I'd try a PR to support it in MinIO. I can understand if this feels too coupled with a single provider, figured I'd try anyway.
This is not a full-fledged implementation, but it works and was enough to get me off the ground running. I'm sure there are edge-cases and configs that are not covered here. I noticed that AWS sdk is not vendored in this project, so I opted to write an implementation from scratch.