update tags regexp to include space character as valid

minio · Sep 28, 2022 · 8848d8a · 8848d8a
1 parent 53f5600
commit 8848d8a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/tags/tags.go b/pkg/tags/tags.go
@@ -69,7 +69,7 @@ const (
 // https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#tag-restrictions
 // borrowed from this article and also testing various ASCII characters following regex
 // is supported by AWS S3 for both tags and values.
-var validTagKeyValue = regexp.MustCompile(`^[a-zA-Z0-9-+\-._:/@]+$`)
+var validTagKeyValue = regexp.MustCompile(`^[a-zA-Z0-9-+\-._:/@ ]+$`)
 
 func checkKey(key string) error {
 	if len(key) == 0 {

diff --git a/pkg/tags/tags_test.go b/pkg/tags/tags_test.go
@@ -31,6 +31,14 @@ func TestParseTags(t *testing.T) {
 			"key1=value1&key2=value2",
 			false,
 		},
+		{
+			"store+forever=false&factory=true",
+			false,
+		},
+		{
+			" store forever =false&factory=true",
+			false,
+		},
 		{
 			fmt.Sprintf("%0128d=%0256d", 1, 1),
 			false,