Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identity new --ip example #467

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix identity new --ip example #467

merged 1 commit into from
Jun 13, 2024

Conversation

ramondeklein
Copy link
Contributor

Fix the kes identity new --ip example so it includes the --key and --cert options (required).

@ramondeklein ramondeklein self-assigned this Jun 11, 2024
@ramondeklein ramondeklein requested a review from aead June 11, 2024 15:32
@ramondeklein ramondeklein linked an issue Jun 11, 2024 that may be closed by this pull request
kes identity new returns: '--ip' requires a private key and certificate file #466
Closed
shtripat
shtripat approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/kes/identity.go Outdated Show resolved Hide resolved
@ramondeklein ramondeklein force-pushed the fix-ip-example branch 2 times, most recently from 7833d4c to a417d4e Compare June 11, 2024 18:01
@aead aead merged commit f111da8 into minio:master Jun 13, 2024
8 checks passed
@djwfyi djwfyi mentioned this pull request Jun 21, 2024
Closed
4 tasks
@ramondeklein ramondeklein deleted the fix-ip-example branch July 16, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

@aead aead aead approved these changes

Assignees

@ramondeklein ramondeklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kes identity new returns: '--ip' requires a private key and certificate file
3 participants
@ramondeklein @shtripat @aead