Deprecate array and string type initialization #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
force-pushed
the
mime-types-3.6-deprecations
branch
3 times, most recently
from
70e85b4
to
aa67cb0
Compare
halostatue
force-pushed
the
mime-types-3.6-deprecations
branch
3 times, most recently
from
65fa04e
to
808a701
Compare
- 2 deprecations: - Array-based MIME::Type initialization - String-based MIME::Type initialization Use of these these will result in deprecation warnings. - Added `logger` to the gemspec to suppress a bundled gem warning with Ruby 3.3.5. This warning should not be showing up until Ruby 3.4.0 is released and will be suppressed in Ruby 3.3.6. - Reworked the deprecation message code to be somewhat more flexible and allow for outputting certain warnings once. Because there will be at least one other release after 3.6, we do not need to make the type initialization deprecations frequent with this release.
halostatue
force-pushed
the
mime-types-3.6-deprecations
branch
from
808a701
to
1586511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 deprecations:
Use of these these will result in deprecation warnings.
Added
loggerto the gemspec to suppress a bundled gem warning withRuby 3.3.5. This warning should not be showing up until Ruby 3.4.0 is
released and will be suppressed in Ruby 3.3.6.