Priority extensions #162
Draft
Priority extensions #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
force-pushed
the
priority-extensions
branch
2 times, most recently
from
e2655aa
to
bb89d13
Compare
halostatue
force-pushed
the
priority-extensions
branch
from
bb89d13
to
46b65aa
Compare
- Added extension priority map. This is an imperfect solution, and is
not used by default with default configuration (column-based data).
- We may want to consider a revised columnar format for a future
version that has a bit more information than is present in the base
file.
- Adding the sort priority and extension priority helped, but because
the alphanumeric sort was first in `MIME::Type#priority_compare`, the
results weren't as good as they should have been. We now sort by the
sort priority values _first_ and the alphanumeric values _second_.
- Stored sort priority was not respected because it depends on flags
not kept in the base file. Added support for a binary file with this
to ensure it is loaded.
halostatue
force-pushed
the
priority-extensions
branch
from
46b65aa
to
c17b330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress.
This change is