enhance: [2.4]createdatabase support properties (#2450)

enhance createdatabase support properties issue: #2447 --------- Signed-off-by: Xianhui.Lin <[email protected]>
milvus-io · Dec 13, 2024 · 364da8b · 364da8b
1 parent eb0c882
commit 364da8b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/pymilvus/client/grpc_handler.py b/pymilvus/client/grpc_handler.py
@@ -1354,8 +1354,14 @@ def get_loading_progress(
         return response.progress
 
     @retry_on_rpc_failure()
-    def create_database(self, db_name: str, timeout: Optional[float] = None, **kwargs):
-        request = Prepare.create_database_req(db_name, **kwargs)
+    def create_database(
+        self,
+        db_name: str,
+        properties: Optional[dict] = None,
+        timeout: Optional[float] = None,
+        **kwargs,
+    ):
+        request = Prepare.create_database_req(db_name, properties=properties, **kwargs)
         status = self._stub.CreateDatabase(request, timeout=timeout)
         check_status(status)
 

diff --git a/pymilvus/milvus_client/milvus_client.py b/pymilvus/milvus_client/milvus_client.py
@@ -1167,9 +1167,9 @@ def using_database(self, db_name: str, **kwargs):
         conn = self._get_connection()
         conn.reset_db_name(db_name)
 
-    def create_database(self, db_name: str, **kwargs):
+    def create_database(self, db_name: str, properties: Optional[dict] = None, **kwargs):
         conn = self._get_connection()
-        conn.create_database(db_name, **kwargs)
+        conn.create_database(db_name, properties, **kwargs)
 
     def drop_database(self, db_name: str, **kwargs):
         conn = self._get_connection()