Enable dynamic schema for high-level newcollection by default (#506)

Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Jun 29, 2023 · 41998f4 · 41998f4
1 parent 0e14519
commit 41998f4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/client/collection.go b/client/collection.go
@@ -113,6 +113,7 @@ func (c *GrpcClient) NewCollection(ctx context.Context, collName string, dimensi
 		VectorFieldName:     "vector",
 		MetricsType:         entity.IP,
 		AutoID:              false,
+		EnableDynamicSchema: true,
 	}
 
 	for _, o := range opts {
@@ -124,7 +125,7 @@ func (c *GrpcClient) NewCollection(ctx context.Context, collName string, dimensi
 		pkField = pkField.WithMaxLength(opt.PrimaryKeyMaxLength)
 	}
 
-	sch := entity.NewSchema().WithName(collName).WithAutoID(opt.AutoID).
+	sch := entity.NewSchema().WithName(collName).WithAutoID(opt.AutoID).WithDynamicFieldEnabled(opt.EnableDynamicSchema).
 		WithField(pkField).
 		WithField(entity.NewField().WithName(opt.VectorFieldName).WithDataType(entity.FieldTypeFloatVector).WithDim(dimension))
 

diff --git a/client/options.go b/client/options.go
@@ -31,6 +31,7 @@ type createCollOpt struct {
 	VectorFieldName     string
 	MetricsType         entity.MetricType
 	AutoID              bool
+	EnableDynamicSchema bool
 }
 
 func WithPKFieldName(name string) CreateCollectionOption {
@@ -69,6 +70,12 @@ func WithAutoID(autoID bool) CreateCollectionOption {
 	}
 }
 
+func WithEnableDynamicSchema(enable bool) CreateCollectionOption {
+	return func(opt *createCollOpt) {
+		opt.EnableDynamicSchema = enable
+	}
+}
+
 // WithConsistencyLevel specifies a specific ConsistencyLevel, rather than using the default ReaderProperties.
 func WithConsistencyLevel(cl entity.ConsistencyLevel) CreateCollectionOption {
 	return func(opt *createCollOpt) {