Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goog plugin upgrade for fix breaking changes #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

diegofer
Copy link

@diegofer diegofer commented Jul 6, 2020

goog plugin upgrade for fix breaking changes in google charts loading using gstatic library like docu in https://developers.google.com/chart/interactive/docs/basic_load_libs#update-library-loader-code

Check my console error before and web app before and after fix:
Captura de pantalla de 2020-07-03 11-00-41
Captura de pantalla de 2020-07-06 12-14-10

goog plugin upgrade for fix breaking changes in google charts loading  using gstatic library like docu in https://developers.google.com/chart/interactive/docs/basic_load_libs#update-library-loader-code
Notes: 
1. due to gstatic google library,  the async plugin it is not necessary anymore.
2. requirejs define only needs two parameters:
<pre><code>
define([
	'goog!current,packages:[corechart]',
],
</code></pre>
goog plugin upgrade for fix breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant