Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bower.js #115

Closed
wants to merge 2 commits into from
Closed

Create bower.js #115

wants to merge 2 commits into from

Conversation

tibbon
Copy link

@tibbon tibbon commented Oct 27, 2014

Created to work with bower and wiredep.

Created to work with bower and wiredep
@sompylasar
Copy link

The Bower manifest file should be bower.json, not bower.js

@tibbon
Copy link
Author

tibbon commented Oct 28, 2014

Doh! Good point. Updating that now.

@stephen-hill
Copy link

+1

@nathanboktae
Copy link
Contributor

@millermedeiros Any reason not to take this? Bower is quite popular....

@millermedeiros
Copy link
Owner

at the time bower was still in flux and I didn't want to maintain multiple *.json files.. (harder to update/release new versions..) specially since this file was linked to a specific commit hash.

for some weird reason I was not getting any email notifications for this project, so I missed most of the bug reports/PRs..

if we add the bower.json now would it work with all releases? (eg. v0.11.0, v0.12.0, v0.12.1) since the old tags won't have a matching bower.json file..

for my own projects I'm basically using npm, volo or basic shell scripts to manage the dependencies..

since I'm not using crossroads on any project at the moment (working mostly on Firefox OS for the past year and half..) I shifted my focus to other libraries/tasks... that's why things are moving slowly here.

@nathanboktae
Copy link
Contributor

Actually I noticed you're already in bower... someone perhaps registered you already? And since you're already tagging repo, you're good. this is a one time thing.

Actually this bower.json shouldn't have the version... not sure why. So yes adding a bower.json is a one time thing unless your dependencies change. See angular-ui-router 's bower.json for an example. I can submit a PR with a cleaner bower.json.

@kennethjor
Copy link

Currently having trouble using Crossroads for a new project because there is no bower.json. Would love to see this PR get accepted.

@nathanboktae
Copy link
Contributor

Given how Miller is very busy, for those of you considering router options still, look at Cherrytree - it is actively maintained hierarchal router with a super clean, simple API - map to define routes, use to add middleware, generate to get a link. That's it. No dependencies, uses Promises instead of a custom pub-sub library.

@tibbon tibbon closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants