Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle stale managedPDB definitions #58

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Handle stale managedPDB definitions #58

merged 1 commit into from
Aug 20, 2024

Conversation

michohl
Copy link
Contributor

@michohl michohl commented Aug 16, 2024

In the reconcile loop there are cases where we are attempting to update a managed PDB that has already been updated in the cluster by something else. This results in the following error:

time="2024-07-17T14:20:46Z" level=error msg="Failed to update PDB: Operation cannot be fulfilled on poddisruptionbudgets.policy \"my-cool-deployment-pdb-controller\": the object has been modified; please apply your changes to the latest version and try again"

This error is mostly harmless since another run of the reconcile loop will usually resolve the error but this change will reduce the noise from the error messages and speed up the time to reconcile PDBs which might have needed multiple reconcile loops to finish their update before.

I have been running this change in our own clusters for a week now and since then we have not received any more of the above errors.

@mikkeloscar
Copy link
Owner

👍

1 similar comment
@szuecs
Copy link
Collaborator

szuecs commented Aug 20, 2024

👍

@szuecs szuecs merged commit 31342e5 into mikkeloscar:master Aug 20, 2024
5 of 6 checks passed
@szuecs
Copy link
Collaborator

szuecs commented Aug 20, 2024

thanks @michohl !

@szuecs
Copy link
Collaborator

szuecs commented Aug 20, 2024

@mikkeloscar I think we need to tag it. Do you do this manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants