Explicitly target a deployment or a statefulset #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most common source of invalid PDBs is the users creating a deployment or a statefulset and a cronjob with the same application and then simply using an application=foo selector. We can add a quick workaround that will explicitly target pods belonging to a deployment or a statefulset to avoid this situation. Signed-off-by: Alexey Ermakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common source of invalid PDBs is the users creating a deployment or a statefulset and a cronjob with the same application and then simply using an application=foo selector. We can add a quick workaround that will explicitly target pods belonging to a deployment or a statefulset to avoid this situation.
TODO: tests.