Fix wrong data format for usrp #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
mrene
reviewed
Aug 10, 2024
| @@ -101,7 +101,7 @@ void usrp_list(void) { | |||
| if (type == NULL || serial == NULL) | |||
| continue; | |||
|
|
|||
| printf("interface {value=usrp-%s-%s}{display=ICE9 Bluetooth%s}\n", product, serial, | |||
There was a problem hiding this comment.
you might want to update usrp_find_serial() - this fails for me since it passes serial=B200mini (xxxxxx),num_recv_frames=1024 as the opening arguments to libuhd (the original code also fails because it looks for the first - instead of the last -).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usrp wasn't able to decode packets due to missing conversion from cs16 to cs8. Fixed by choosing the right format. Also changed the way the serial is printed as otherwise the -i option isn't parsed correctly. Furthermore added the needed import for clang 16 and higher (ubuntu 24.04 LTS).