-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for actions for notify-send version >=0.8.2 #445
Open
marmul
wants to merge
16
commits into
mikaelbr:master
Choose a base branch
from
marmul:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…args several times. Changed constructArgumentList to split array arguments when requested by extra options.
…x of selected action with action name. Use example/toaster-with-actions.js to test.
… example/toaster-with-actions.js for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 23.10 and Ubuntu 24.04 are shipped with notify-send and libnotify versions >=0.8.2, so it supports notification actions.
https://manpages.ubuntu.com/manpages/mantic/en/man1/notify-send.1.html
The "--action" option needs to be set multiple times if there are multiple actions. I hacked something together that does that. I also wanted to use events with those actions, but for some reason had to refactor NotifySend into an ES6 class to make it work.
Only tested on Ubuntu 24.04 so far. Hints and comments welcome.