Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript typings packages listed as runtime dependencies #53

Open
cubabit opened this issue May 31, 2018 · 1 comment · May be fixed by #116
Open

Typescript typings packages listed as runtime dependencies #53

cubabit opened this issue May 31, 2018 · 1 comment · May be fixed by #116

Comments

@cubabit
Copy link

cubabit commented May 31, 2018

Is it correct that the typescript typings modules are listed as non-dev dependencies?

https://github.com/mientjan/react-native-markdown-renderer/blob/master/package.json#L27

I am using a lower version of @types/react-native in my project and the dependency in react-native-markdown-renderer's is causing my react native packager to fail with the following:

Failed to build DependencyGraph: @providesModule naming collision: Duplicate module name: @types/react-native
@mientjan
Copy link
Owner

mientjan commented Jun 4, 2018

Thats because they are used in the d.ts file https://github.com/mientjan/react-native-markdown-renderer/blob/master/src/index.d.ts#L2 maybe move them to a peer Dependency???

@liamfd liamfd linked a pull request Jul 24, 2019 that will close this issue
Open
@aekaisato aekaisato mentioned this issue Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move @types/react-native to Peer Dependencies fabrictech/react-native-markdown-renderer
2 participants
@cubabit @mientjan