Move @types/react-native to Peer Dependencies #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
@types/react-native
dependency to peer dependencies.For context, this is useful because otherwise, a user of this library with a direct dependency on
@types/react-native
can wind up with two different versions of the@types/react-native
installed, one undernode_modules/@types/react-native
and one undernode_modules/react-native-markdown-renderer/node_modules/@types/react-native
. That results in TypeScript errors like:This should resolve #53.
There's another PR for this here: #113, but it appears to make extraneous changes and hasn't seen any responses. I don't mean to step on any toes, just figured this was a more direct way to get a more focused PR up.
I only have a sample size of 1, but this change works in my project, and does not break the existing typing as far as I can tell.
If there's anything I can do to help get this across the line, please let me know.